ref: Add tracing.http_client_requests option (#641)

getsentry · Jan 31, 2023 · d64cf29 · d64cf29
1 parent eb6eec1
commit d64cf29
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 0 deletions.
diff --git a/config/sentry.php b/config/sentry.php
@@ -44,6 +44,9 @@
         // Capture views as spans
         'views' => true,
 
+        // Capture HTTP client requests as spans
+        'http_client_requests' => true,
+
         // Indicates if the tracing integrations supplied by Sentry should be loaded
         'default_integrations' => true,
 

diff --git a/src/Sentry/Laravel/Tracing/EventHandler.php b/src/Sentry/Laravel/Tracing/EventHandler.php
@@ -79,6 +79,13 @@ class EventHandler
      */
     private $traceQueueJobsAsTransactions;
 
+    /**
+     * Indicates if we should trace HTTP client requests.
+     *
+     * @var bool
+     */
+    private $traceHttpClientRequests;
+
     /**
      * Hold the stack of parent spans that need to be put back on the scope.
      *
@@ -108,6 +115,8 @@ public function __construct(array $config, BacktraceHelper $backtraceHelper)
         $this->traceSqlQueries = ($config['sql_queries'] ?? true) === true;
         $this->traceSqlQueryOrigins = ($config['sql_origin'] ?? true) === true;
 
+        $this->traceHttpClientRequests = ($config['http_client_requests'] ?? true) === true;
+
         $this->traceQueueJobs = ($config['queue_jobs'] ?? false) === true;
         $this->traceQueueJobsAsTransactions = ($config['queue_job_transactions'] ?? false) === true;
 
@@ -283,6 +292,10 @@ protected function transactionRolledBackHandler(DatabaseEvents\TransactionRolled
 
     protected function httpClientRequestSendingHandler(HttpClientEvents\RequestSending $event): void
     {
+        if (!$this->traceHttpClientRequests) {
+            return;
+        }
+
         $parentSpan = SentrySdk::getCurrentHub()->getSpan();
 
         // If there is no tracing span active there is no need to handle the event
@@ -300,6 +313,10 @@ protected function httpClientRequestSendingHandler(HttpClientEvents\RequestSendi
 
     protected function httpClientResponseReceivedHandler(HttpClientEvents\ResponseReceived $event): void
     {
+        if (!$this->traceHttpClientRequests) {
+            return;
+        }
+
         $span = $this->popSpan();
 
         if ($span !== null) {
@@ -310,6 +327,10 @@ protected function httpClientResponseReceivedHandler(HttpClientEvents\ResponseRe
 
     protected function httpClientConnectionFailedHandler(HttpClientEvents\ConnectionFailed $event): void
     {
+        if (!$this->traceHttpClientRequests) {
+            return;
+        }
+
         $span = $this->popSpan();
 
         if ($span !== null) {