Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sveltekit): Add SvelteKit 2.0 to peer dependency range #9861

Merged
merged 2 commits into from
Dec 19, 2023
Merged

chore(sveltekit): Add SvelteKit 2.0 to peer dependency range #9861

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f505ac
chore(sveltekit): Add SvelteKit 2.0 to peer dependency range
Lms24 Dec 15, 2023
48fbe6b
explicit version range
Lms24 Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/sveltekit/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"access": "public"
},
"peerDependencies": {
"@sveltejs/kit": "1.x"
"@sveltejs/kit": ">=1.x"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be a bit more cautious, should we make this >= 1 <= 2?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can ofc but for example, in Astro, we opted to leave an open end given that we'll need support for a new major anyway (#9683)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine with me 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather we explicitly opt-in to every major version, and make this "@sveltejs/kit": "^1.0 || ^2.0" like what we do for nextjs.

Copy link
Member Author

@Lms24 Lms24 Dec 15, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, changed it to an explicit major array. Don't have strong opinions here, so fine with anything 😅

},
"dependencies": {
"@sentry-internal/tracing": "7.88.0",
Expand Down