Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta(changelog): Update Changelog for 7.50.0 #7966

Merged
merged 29 commits into from
Apr 26, 2023
Merged

Conversation

mydea
Copy link
Member

@mydea mydea commented Apr 26, 2023

This is a big release!

mydea and others added 22 commits April 20, 2023 17:19
[Gitflow] Merge master into develop

Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
)

This adds a public API: `capture` that will record the current event buffer and by default, convert the replay type to "session" and continue recording. We have extracted the logic that was used for "onError" capturing and made it a public API.
Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
)

`stop()` will now flush the eventBuffer before clearing it, as well as removing the session from Session Storage. Due to the flushing, `stop()` is now async.

Closes: #7738
Bumps [yaml](https://github.com/eemeli/yaml) from 2.1.1 to 2.2.2.
- [Release notes](https://github.com/eemeli/yaml/releases)
- [Commits](eemeli/yaml@v2.1.1...v2.2.2)

---
updated-dependencies:
- dependency-name: yaml
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Not sure where I got the `closed` stuff from, but this seems to be actually correct based on https://docs.github.com/en/webhooks-and-events/webhooks/webhook-events-and-payloads#issues.
)

This is to avoid infinite recursion that we cannot detect, e.g. when using dynamic proxies.
Now, a session will only expire & trigger a new session if no user activity happened for 15min. 

After 5min of inactivity, we will pause recording events. If the user resumes in the next 10 minutes, we'll resume the session, else re-create it if they resume later.
)

By default, we only multiplex errors, but allow to opt-in to more envelope types.
@mydea mydea self-assigned this Apr 26, 2023
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changelog seems pretty lengthy, could we shorten it - or create another doc that users can go read if they are interested?

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@mydea
Copy link
Member Author

mydea commented Apr 26, 2023

This changelog seems pretty lengthy, could we shorten it - or create another doc that users can go read if they are interested?

I extracted some of it out into the readme of replay and linked there!

* feat: Add `startBuffering()` API to begin replay buffering. This is useful if you turn off `replaysSessionSampleRate` and `replaysOnErrorSampleRate` and want to manually decide when to start replay buffering. You can then call `flush()` to save the replay.
* fix: Sample at a per error rate instead of per session rate. Previously we were sampling at a per-session rather than per-error. This means the sampling decision happened prior to any error occurrence. The sampling rate was not accurate if you had sessions with many errors. This is now changed so that in the case of capturing replays only on error, we begin buffering the replay immediately and only run the sampling decision when an error occurs.
@mydea mydea marked this pull request as ready for review April 26, 2023 13:48
@mydea mydea changed the base branch from develop to master April 26, 2023 13:49
@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2023

⚠️ This PR is opened against master. You probably want to open it against develop.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 21.03 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 65.66 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.56 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 58.12 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.17 KB (0%)
@sentry/browser - Webpack (minified) 69.07 KB (0%)
@sentry/react - Webpack (gzipped + minified) 21.19 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 49.03 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.59 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.82 KB (+0.01% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 46.81 KB (+0.54% 🔺)
@sentry/replay - Webpack (gzipped + minified) 40.59 KB (+0.57% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 65.62 KB (+0.43% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 58.57 KB (+0.42% 🔺)

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the last-minute adjustments!

CHANGELOG.md Outdated Show resolved Hide resolved
@mydea mydea merged commit f3bfe11 into master Apr 26, 2023
61 checks passed
@mydea mydea deleted the prepare-release/7.50.0 branch April 26, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants