Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: Update CHANGELOG for 7.45.0 #7588

Merged
merged 35 commits into from
Mar 23, 2023
Merged

meta: Update CHANGELOG for 7.45.0 #7588

merged 35 commits into from
Mar 23, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Mar 23, 2023

Changelog for 7.45.0

AbhiPrasad and others added 30 commits March 21, 2023 13:17
[Gitflow] Merge master into develop
…uests (#7553)

We noticed that sometimes request would remain in a seemingly pending state.
After some investigation, we found out that the limit of 64kb for keepalive-enabled fetch requests is not per request but for all parallel requests running at the same time.

This fixes this by keeping track of how large the pending body sizes are, plus the # of pending requests, and setting keepalive accordingly.
```js
const fetchResult = Sentry.trace({ name: 'GET /users'}, () => fetch('/users'), handleError);
```
Add routing instrumentation to the client SvelteKit SDK. Pageload navigations are created on function call as always and updated with a proper name once the `page` store emits the route id. Navigation transactions are created by subscribing to the `navigating` store.  No need for user configuration, as the instrumentation will be added automatically on SDK intialization.
…hSentry` (#7567)

Our E2E tests were [failing](https://github.com/getsentry/sentry-javascript/actions/runs/4488942749/jobs/7894376591#step:6:6185) because apparently we don't initialize a client while building a NextJS app. This caused the tracing extension methods to not be added, resulting in `startTransaction` returning `undefined`. Not sure if this is the best way to fix this but it seems to work (h/t @timfish for the fix).
If `error.cause` is already defined, attempt to walk down the error chain to set the `ReactErrorBoundary` error.
We now run all tests into a single spawned process, which should hopefully speed this up a bit.
We also reduce the # of repetitions from 100 to 50 to ensure we do not run overtime.
---------

Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
timfish and others added 4 commits March 23, 2023 11:02
We discovered that our serverside `handleLoadWithSentry` wrapper caused two distinct transactions being created on page loads - one for the page load request and one for the `load` function (if one exists for that page). This shouldn't happen. We need to investigate how to fix this. 

As a short-term solution, we disable tracing on the serverside load wrapper to avoid quota usage increase for our users.
…tly (#7584)

Previously our Kit routing instrumentation used the parameterized route id to determine if the origin and destination of the navigation were identical (in which case we don't want to create a navigation transaction). 
This caused navigations from e.g. `/users/123` to `users/456` to not create a transaction because their route id was identical. This PR fixes this bug by using the raw URL which we also get from the `navigating` store emissions. 

Furthermore, this PR fixes the transaction source which previously was always set to `route`, even if no route id was available.
@Lms24 Lms24 requested review from mydea and AbhiPrasad March 23, 2023 11:55
@@ -4,6 +4,24 @@

- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott

## 7.45.0

- build(cdn): Ensure ES5 bundles do not use non-ES5 code (#7550)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we usually don't include build stuff but since this fixes a bug, let's leave it in

@Lms24 Lms24 changed the base branch from develop to master March 23, 2023 11:57
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.57 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 64.2 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.13 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 56.58 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.59 KB (0%)
@sentry/browser - Webpack (minified) 71.66 KB (0%)
@sentry/react - Webpack (gzipped + minified) 21.61 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 51.87 KB (-0.02% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 27.92 KB (-0.05% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.1 KB (-0.04% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 44.33 KB (0%)
@sentry/replay - Webpack (gzipped + minified) 38.39 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 62.53 KB (-0.02% 🔽)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 56.07 KB (0%)

@Lms24 Lms24 merged commit 79fa14b into master Mar 23, 2023
@Lms24 Lms24 deleted the prepare-release/7.45.0 branch March 23, 2023 13:09
Lms24 added a commit that referenced this pull request Mar 23, 2023
Lms24 added a commit that referenced this pull request Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants