Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdn): Fix es5 CDN bundles #7544

Merged
merged 1 commit into from
Mar 21, 2023
Merged

fix(cdn): Fix es5 CDN bundles #7544

merged 1 commit into from
Mar 21, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Mar 21, 2023

We need to add packages to the ts plugin config, otherwise they are not correctly ES5 transpiled. I also added this to the checklist.

I will merge this PR into master and cut a release so we can do a bugfix release (there is already a feature on develop).

Closes #7541

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.5 KB (-0.14% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 63.83 KB (-0.04% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.19 KB (-0.02% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 56.92 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.66 KB (0%)
@sentry/browser - Webpack (minified) 72.12 KB (0%)
@sentry/react - Webpack (gzipped + minified) 21.7 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 52.02 KB (-0.07% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 27.81 KB (-17.63% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.13 KB (0%)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 44.23 KB (0%)
@sentry/replay - Webpack (gzipped + minified) 38.28 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 62.44 KB (0%)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 55.99 KB (+0.01% 🔺)

@mydea mydea merged commit ae2c1a5 into master Mar 21, 2023
@mydea mydea deleted the fn/fix-es5-build branch March 21, 2023 09:14
@Progdom
Copy link

Progdom commented Mar 21, 2023

This is still broken and not correctly outputting es5. Using are-you-es5.

❌ @sentry/browser is not ES5
❌ @sentry/integrations is not ES5

"@sentry/browser": "7.44.2",
"@sentry/integrations": "7.44.2",

@mydea
Copy link
Member Author

mydea commented Mar 22, 2023

This is only about the CDN bundles, not the NPM packages (which are-you-es5 checks, as far as I can tell?). If you are using the NPM modules, you have to take care of transpiling this to ES5 yourself!

At least I haven't found a way to make are-you-es5 work with a CDN bundle?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants