Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix): Pass transaction name as route to RequestData. #6276

Merged
merged 1 commit into from Nov 24, 2022

Conversation

onurtemizkan
Copy link
Collaborator

Ref: #6139 - #6139 (comment)

Passing transaction names as custom routes to RequestData integration:

Custom routes in RequestData ⬇️

// Check to see if there's a parameterized route we can use (as there is in Express)
if (options.customRoute || req.route) {
path = options.customRoute || `${req.baseUrl || ''}${req.route && req.route.path}`;
source = 'route';
}

This displays the transaction name prefixed by the method as below:

Screenshot 2022-11-23 at 15 39 06

@onurtemizkan onurtemizkan changed the title fix(remix): Pass parameterized route to RequestData. fix(remix): Pass transaction name as route to RequestData. Nov 23, 2022
@onurtemizkan onurtemizkan linked an issue Nov 23, 2022 that may be closed by this pull request
3 tasks
@lforst lforst self-requested a review November 24, 2022 10:06
Copy link
Member

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thank you! :)

@lforst lforst merged commit 9f522c9 into master Nov 24, 2022
@lforst lforst deleted the onur/remix-parameterize-requestdata-url branch November 24, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remix - No URL included with issues
2 participants