fix(remix): Attempt to extract user IP from request headers. #6263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #6139 - #6139 (comment)
Remix requests don't contain client IP addresses in
req.ip
orreq.socket.*
.To extract them, we need to iterate over a set of request headers that may contain that info.
I have vendored / modified an implementation of that function from third-party utility set
remix-utils
. (Using as a dependency is not possible because of incompatible TS syntax.)It's still the best effort and may also need improvements over header key prioritization.