Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(otel): Update README to add alpha note #6169

Merged
merged 2 commits into from Nov 9, 2022

Conversation

AbhiPrasad
Copy link
Member

ref #6000

Add an alpha note that indicates that this package is experimental (for now!)

@AbhiPrasad AbhiPrasad added this to the OpenTelemetry Support milestone Nov 9, 2022
@AbhiPrasad AbhiPrasad self-assigned this Nov 9, 2022
@AbhiPrasad AbhiPrasad mentioned this pull request Nov 9, 2022
10 tasks
packages/opentelemetry-node/README.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.5 KB (0%)
@sentry/browser - ES5 CDN Bundle (minified) 60.34 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.15 KB (-0.01% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 53.69 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 19.89 KB (0%)
@sentry/browser - Webpack (minified) 65.1 KB (0%)
@sentry/react - Webpack (gzipped + minified) 19.91 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 46.02 KB (+0.27% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.35 KB (+0.09% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.75 KB (+0.1% 🔺)

@@ -10,6 +10,11 @@
[![npm dm](https://img.shields.io/npm/dm/@sentry/opentelemetry-node.svg)](https://www.npmjs.com/package/@sentry/opentelemetry-node)
[![npm dt](https://img.shields.io/npm/dt/@sentry/opentelemetry-node.svg)](https://www.npmjs.com/package/@sentry/opentelemetry-node)

This package allows you to send your NodeJS OpenTelemetry trace data to Sentry via OpenTelemetry SpanProcessors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: We maybe also want to mention that this only affects performance/transaction data, not errors, but we can also further extend on this readme later.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about this, but given we might add the ability to capture errors I thought against it. Maybe later!

Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) November 9, 2022 13:34
@AbhiPrasad AbhiPrasad merged commit ccb3ad6 into master Nov 9, 2022
@AbhiPrasad AbhiPrasad deleted the abhi-otel-readme-note branch November 9, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants