Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Check that functions have been called in beforeSend and beforeSendTransaction tests #6150

Conversation

lobsterkatie
Copy link
Member

Per @Lms24's suggestion, this adds a check to make sure the relevant function is being called in our beforeSend and beforeSendTransaction tests.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.5 KB (+0.06% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 60.37 KB (+0.04% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.15 KB (+0.19% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 53.71 KB (+0.07% 🔺)
@sentry/browser - Webpack (gzipped + minified) 19.89 KB (+0.17% 🔺)
@sentry/browser - Webpack (minified) 65.12 KB (-0.01% 🔽)
@sentry/react - Webpack (gzipped + minified) 19.92 KB (+0.19% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 45.82 KB (+0.06% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.28 KB (+0.06% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.67 KB (+0.12% 🔺)

@lobsterkatie lobsterkatie merged commit 1f3fc98 into master Nov 8, 2022
@lobsterkatie lobsterkatie deleted the kmclb-add-called-check-to-beforeSend-and-beforeSendTransaction-tests branch November 8, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants