New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nextjs): Do not exit process when errors bubble up while additional uncaughtException
-handlers are registered
#6138
Merged
lforst
merged 10 commits into
master
from
lforst-fix-nextjs-quitting-on-aborted-requests
Nov 4, 2022
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
8922b5b
feat(node): Add option to `OnUncaughtException` integration that allo…
lforst 55ed724
fix(nextjs): Do not exit process when errors bubble up while addition…
lforst 71bcfe0
cleanup
lforst f405686
Change option name
lforst 193ef4f
Merge branch 'lforst-mimic-native-behaviour-onuncaught-exception' int…
lforst 74ab0bd
Rename option
lforst 05bfb5e
Rephrase JSDoc
lforst 2ddefff
Merge remote-tracking branch 'origin/lforst-mimic-native-behaviour-on…
lforst 85faa2a
Rename option
lforst 0157588
Merge branch 'master' into lforst-fix-nextjs-quitting-on-aborted-requ…
lforst File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little confused by this. The point of
addOrUpdateIntegration
is to say, "here's the integration to add if no instance is already there, but if an instance is there, update it with these options." This means that the integration to add should have the same options as the the ones which are being updated.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I assumed the options didn't matter since the
UncaughtException
integration is part of the default integrations anyways but you're right - we should add the options in case the users override the integration.