Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(otel): Add @opentelemetry/core package #6108

Merged
merged 2 commits into from Nov 2, 2022
Merged

feat(otel): Add @opentelemetry/core package #6108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f4007d
feat(otel): Add `@opentelemetry/core` package
AbhiPrasad Nov 2, 2022
a3f4c82
add @opentelemetry/semantic-conventions
AbhiPrasad Nov 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/opentelemetry-node/package.json
View file
Open in desktop
Expand Up @@ -24,13 +24,16 @@
},
"peerDependencies": {
"@opentelemetry/api": "1.x",
"@opentelemetry/core": "1.x",
"@opentelemetry/sdk-trace-base": "1.x",
"@opentelemetry/semantic-conventions": "1.x"
},
"devDependencies": {
"@opentelemetry/api": "^1.2.0",
"@opentelemetry/core": "^1.7.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: I think we can only add this to peerDependencies and leave it as a transitive dependency in dev deps. but also OK to add it explicitly, I guess! If we want to leave it here, we should also add @opentelemetry/semantic-conventions as devDependency for symmetry!

"@opentelemetry/sdk-trace-base": "^1.7.0",
"@opentelemetry/sdk-trace-node": "^1.7.0"
"@opentelemetry/sdk-trace-node": "^1.7.0",
"@opentelemetry/semantic-conventions": "^1.7.0"
},
"scripts": {
"build": "run-p build:rollup build:types",
Expand Down
4 changes: 2 additions & 2 deletions yarn.lock
View file
Open in desktop
Expand Up @@ -3913,7 +3913,7 @@
resolved "https://registry.yarnpkg.com/@opentelemetry/context-base/-/context-base-0.14.0.tgz#c67fc20a4d891447ca1a855d7d70fa79a3533001"
integrity sha512-sDOAZcYwynHFTbLo6n8kIbLiVF3a3BLkrmehJUyEbT9F+Smbi47kLGS2gG2g0fjBLR/Lr1InPD7kXL7FaTqEkw==

"@opentelemetry/core@1.7.0":
"@opentelemetry/core@1.7.0", "@opentelemetry/core@^1.7.0":
version "1.7.0"
resolved "https://registry.yarnpkg.com/@opentelemetry/core/-/core-1.7.0.tgz#83bdd1b7a4ceafcdffd6590420657caec5f7b34c"
integrity sha512-AVqAi5uc8DrKJBimCTFUT4iFI+5eXpo4sYmGbQ0CypG0piOTHE2g9c5aSoTGYXu3CzOmJZf7pT6Xh+nwm5d6yQ==
Expand Down Expand Up @@ -3980,7 +3980,7 @@
"@opentelemetry/sdk-trace-base" "1.7.0"
semver "^7.3.5"

"@opentelemetry/semantic-conventions@1.7.0":
"@opentelemetry/semantic-conventions@1.7.0", "@opentelemetry/semantic-conventions@^1.7.0":
version "1.7.0"
resolved "https://registry.yarnpkg.com/@opentelemetry/semantic-conventions/-/semantic-conventions-1.7.0.tgz#af80a1ef7cf110ea3a68242acd95648991bcd763"
integrity sha512-FGBx/Qd09lMaqQcogCHyYrFEpTx4cAjeS+48lMIR12z7LdH+zofGDVQSubN59nL6IpubfKqTeIDu9rNO28iHVA==
Expand Down