feat(otel): Add propagator #6095
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
So this is pretty much feature complete, but hard to review. I'm gonna split this up into three phases
and then close this PR |
5 tasks
mydea
reviewed
Nov 2, 2022
| @@ -1,3 +1,4 @@ | |||
| import '@sentry/tracing'; | |||
|
|
|||
| export { SentrySpanProcessor } from './spanprocessor'; | |||
| export { SentryPropogator } from './propogator'; | |||
There was a problem hiding this comment.
I think this should be propagator, not propogator? (both in the filename & class name)
There was a problem hiding this comment.
Yup, fixed this afterwards, see: #6109
I literally spelled it wrong everywhere 😭
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #6000
Will be closed and split up don't get attached folks
Edit: Worked is split up and being tracked in #6095, so closing this PR.