Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(e2e): Don't run E2E tests on forked PRs #6063

Merged
merged 1 commit into from Oct 27, 2022
Merged

ci(e2e): Don't run E2E tests on forked PRs #6063

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Expand Up @@ -620,7 +620,7 @@ jobs:
job_e2e_tests:
name: E2E Tests
# We only run E2E tests for non-fork PRs because the E2E tests require secrets to work and they can't be accessed from forks
if: github.repository == 'getsentry/sentry-javascript'
if: github.event.pull_request.head.repo.full_name == github.repository
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to skip the e2e tests in general, wonder why the initial check doesn't work.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What makes you think that? Tried here in a non-fork and they are executed: #6064

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • github.event.pull_request.head.repo.full_name is equal to the repository where the HEAD is located.
  • github.repository is equal to the repository where CI runs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That it was skipped here https://github.com/getsentry/sentry-javascript/actions/runs/3337046260/jobs/5523555712

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is because this PR comes from a fork - to test this behaviour

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I’m a complete dummy - didn’t even take that in. Well then awesome :shipit:

needs: [job_get_metadata, job_build]
runs-on: ubuntu-latest
timeout-minutes: 10
Expand Down