Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remix): Add RequestData integration to captureRemixServerException #6033

Conversation

onurtemizkan
Copy link
Collaborator

@lobsterkatie -- I'm not sure if this patch is valid (or complete), but it fixes events missing request objects in tests of #6007.

  • Adds setSDKProcessingMetadata to Remix exception capturing utility.
  • Also adds it to the wrapper for Express adapters.

@onurtemizkan onurtemizkan force-pushed the onur/remix-RequestData-error-express branch from a98dc28 to 65488fc Compare October 24, 2022 21:08
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.41 KB (-0.38% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 60.09 KB (-0.36% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.03 KB (-0.45% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 53.44 KB (-0.39% 🔽)
@sentry/browser - Webpack (gzipped + minified) 19.79 KB (-0.32% 🔽)
@sentry/browser - Webpack (minified) 64.93 KB (-0.19% 🔽)
@sentry/react - Webpack (gzipped + minified) 19.81 KB (-0.33% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 45.53 KB (-0.59% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 25.86 KB (-1.53% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.29 KB (-1.44% 🔽)

@lobsterkatie
Copy link
Member

Oh, nice. Thanks for figuring that out!

Do you mind if I pull these changes into my PR, so everything is in one place?

@onurtemizkan
Copy link
Collaborator Author

Not at all! The PR is targeted to your branch. I forgot to mention it 😅

@lobsterkatie
Copy link
Member

lobsterkatie commented Oct 25, 2022

Oh, I didn't even notice! Thanks.

(Since it's not a lot of code, for ease of rebasing, etc, I'm going to just copy into my branch rather than merging.)

@lobsterkatie lobsterkatie force-pushed the kmclb-remix-enable-RequestData-integration branch from bc9c930 to b08642e Compare October 27, 2022 06:58
@lobsterkatie lobsterkatie deleted the onur/remix-RequestData-error-express branch October 27, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants