Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ember): Show warning when using invalid config #6032

Merged
merged 1 commit into from Oct 28, 2022
Merged

chore(ember): Show warning when using invalid config #6032

merged 1 commit into from Oct 28, 2022

Commits on Oct 27, 2022

  1. chore(ember): Show warning when using invalid config 

    When defining Sentry config in `ENV['@sentry/ember'].sentry`, this goes through @embroider/macros under the hood. This relies on config being serializable, which means that e.g. you cannot use regex in the config.

To make this easier to pin down (as the error message can be a bit cryptic), this now validates the passed config (based on embroider-build/embroider#1083) and shows a helpful warning message.

Note that this also moved this around a bit, leading to config being written only once on build, which should be a bit faster.
    @mydea
    mydea committed Oct 27, 2022
    Copy the full SHA
    db9998d View commit details
    Browse the repository at this point in the history