Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(otel): Add initial package for otel #6002

Merged
merged 4 commits into from Oct 24, 2022
Merged

Conversation

AbhiPrasad
Copy link
Member

ref: #6000

Add boilerplate package for OpenTelemetry Node.

I would like to make this a separate package because we are dependent on the https://github.com/open-telemetry/opentelemetry-js-api, and I don't want to include that as a dependency for everyone else.

The nice thing is that we can require the usage of @sentry/tracing, so users only have to install @sentry/opentelemetry-node! Aka either use @sentry/tracing OR use @sentry/opentelemetry-node.

As such, installation looks like so:

yarn add @sentry/node @sentry/opentelemetry-node

@AbhiPrasad AbhiPrasad mentioned this pull request Oct 20, 2022
10 tasks
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I like the idea of having this in its own package. Just had a two remarks/questions.

Another question: Do you see any problems with the approach of the Otel package requiring sentry/tracing? I'm thinking for example about our long-term plan of splitting up or integrating the tracing package into browser/node so that users only have to install one package anymore.

packages/opentelemetry-node/README.md Outdated Show resolved Hide resolved
packages/opentelemetry-node/yarn.lock Outdated Show resolved Hide resolved
@AbhiPrasad
Copy link
Member Author

Another question: Do you see any problems with the approach of the Otel package requiring sentry/tracing? I'm thinking for example about our long-term plan of splitting up or integrating the tracing package into browser/node so that users only have to install one package anymore.

Discussed this offline - the answer is: yes it might have consequences, but for now not going to worry about it until v8.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.41 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 60.09 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.04 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 53.44 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 19.79 KB (0%)
@sentry/browser - Webpack (minified) 64.93 KB (0%)
@sentry/react - Webpack (gzipped + minified) 19.81 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 45.53 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 25.86 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.29 KB (+0.01% 🔺)

@AbhiPrasad AbhiPrasad merged commit ce68f87 into master Oct 24, 2022
@AbhiPrasad AbhiPrasad deleted the abhi-add-otel-node-package branch October 24, 2022 07:32
@AbhiPrasad AbhiPrasad added this to the OpenTelemetry Support milestone Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants