Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(utils): Deprecate getGlobalObject as it's no longer used #5949

Merged
merged 2 commits into from Oct 13, 2022
Merged

ref(utils): Deprecate getGlobalObject as it's no longer used #5949

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4909e0e
Remove getGlobalObject as it's no longer used
timfish Oct 13, 2022
4be168b
Deprecate instead!
timfish Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/utils/src/global.ts
View file
Open in desktop
Expand Up @@ -73,9 +73,7 @@ export const GLOBAL_OBJ: InternalGlobal =
{};

/**
* Safely get global scope object
*
* @returns Global scope object
* @deprecated Use GLOBAL_OBJ instead. This will be removed in v8
*/
export function getGlobalObject<T>(): T & InternalGlobal {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now let's deprecate this just in case, and we can remove in v8 - I know we don't have to follow semvar in utils, but getGlobalObject might be more commonly used than other functions, and doesn't cost us much to just wait.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, better idea!

return GLOBAL_OBJ as T & InternalGlobal;
Expand Down