Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(nextjs): Don't assert existance of pageProps in _app #5945

Merged
merged 3 commits into from Oct 13, 2022
Merged

ref(nextjs): Don't assert existance of pageProps in _app #5945

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d0dd7f3
ref(nextjs): Don't assert existance of `pageProps` in `_app`
lforst Oct 13, 2022
8254d76
Update packages/nextjs/src/config/wrappers/withSentryServerSideAppGet…
lforst Oct 13, 2022
efcaac5
Add test
lforst Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/nextjs/src/config/wrappers/withSentryServerSideAppGetInitialProps.ts
View file
Open in desktop
Expand Up @@ -45,6 +45,15 @@ export function withSentryServerSideAppGetInitialProps(origAppGetInitialProps: A
});

const requestTransaction = getTransactionFromRequest(req);

// Per definition, `pageProps` is not optional, however an increased amount of users doesn't seem to call
// `App.getInitialProps(appContext)` in their custom`_app` pages which is required as per
lforst marked this conversation as resolved.
Show resolved Hide resolved
// https://nextjs.org/docs/advanced-features/custom-app - resulting in missing `pageProps`.
// For this reason, we just handle the case where `pageProps` doesn't exist explicitly.
if (!appGetInitialProps.pageProps) {
appGetInitialProps.pageProps = {};
}

if (requestTransaction) {
appGetInitialProps.pageProps._sentryTraceData = requestTransaction.toTraceparent();

Expand Down