Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): Update types to match react router updates #5915

Closed
wants to merge 2 commits into from

Conversation

philipatkinson
Copy link
Contributor

Fixes a type mismatch caused by change remix-run/react-router#9366 in react-router code.

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

Fixes a type mismatch caused by change remix-run/react-router#9366 in react-router code.
@AbhiPrasad AbhiPrasad changed the title Update Types to Match React Router Updates fix(react): Update types to match react router updates Oct 7, 2022
@AbhiPrasad
Copy link
Member

Hey thanks for writing in! It seems this is causing some test failures with typing issues with createRoutesFromChildren

@philipatkinson
Copy link
Contributor Author

Yes, I think this is because the devDependency in Sentry is set to react-router-dom 6.3 rather than 6.4.X. Had a quick fiddle to see if I could update and test easily, but yarn update was throwing out some strange errors. Will revisit when I have the chance to look in more detail (or we could leave it until the dependency naturally catches up and see if the tests pass then).

@bcentdev
Copy link

Ey! Do you have a forecast for when it will be available? Thanks :)

@AbhiPrasad
Copy link
Member

Created #5992 to fix the test failures, will be shipped with the next release!

@AbhiPrasad AbhiPrasad closed this Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants