Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): Rename nextjs.data.server ops #5830

Merged
merged 2 commits into from Sep 28, 2022
Merged

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Sep 27, 2022

As per the span operation audit, this transaction is a http request processed on the server, so we should rename the span op.

https://www.notion.so/sentry/Set-up-an-audit-for-SDK-consistency-for-span-operations-to-enable-performance-issues-addf02a8fa234dda8acf48d4ff9b8efb?d=b852bdd1e9914d2ca74c1052296081f3#d04af01302604881999b1bd29c837b1f

ref: #5837

nextjs.data.server -> http.server for transactions, and nextjs.data.server -> function.nextjs for spans.

@lforst
Copy link
Member

lforst commented Sep 27, 2022

Tests fail

@AbhiPrasad AbhiPrasad changed the title fix(nextjs): Rename data fetch span op to http.server fix(nextjs): Rename nextjs.data.server ops Sep 27, 2022
@AbhiPrasad AbhiPrasad merged commit fac1103 into master Sep 28, 2022
@AbhiPrasad AbhiPrasad deleted the abhi-nextjs-data-fetcher branch September 28, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants