ref(nextjs): Add @sentry/cli as a dependency

[kevinji]

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

• If you've added code that should be tested, please add tests.
• Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

Since @sentry/cli is included to grab its binary, I believe it should also be added explicitly as a dependency.

[AbhiPrasad]

Hey, thanks for opening a PR! @sentry/cli is a dependency of the Sentry webpack plugin, which is a dependency on the NextJS package: https://github.com/getsentry/sentry-webpack-plugin/blob/db1475ef40e8ef7c8341c2878d51dbf4a3e134eb/package.json#L21. It is the webpack plugin that is grabbing the binary and using it.

As such, I think we do not need explicitly add @sentry/cli to our dependency list.

[kevinji]

Gotcha, should it be added as an optional peerDependency then, like how webpack is added? Yarn PnP is unhappy that the nextjs package calls require.resolve('@sentry/cli') unless that's added.

Also, I force pushed a commit but not sure where it went; maybe I need to create a new PR if this one is closed?

[AbhiPrasad]

Yarn PnP is unhappy that the nextjs package calls require.resolve('@sentry/cli')

This might be fixed in v7, can you give that a try and report back? #4882 (you'll also get some bundle size wins as a reward :) )

[kevinji]

Still running into the same error in v7:

Error: @sentry/nextjs tried to access @sentry/cli, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

Required package: @sentry/cli
Required by: @sentry/nextjs@virtual:47772ab7c7059053605926617210fe2785345409fd135f03ed9af243268dc5833d9029118ee3ce335f653f9967b5898a7ad39a4cf9aa079aa83339f36ef2f816#npm:7.0.0

[danielchabr]

If only @sentry/webpack-plugin accessed @sentry/cli then it would be fine but it seems that @sentry/nextjs tries to access @sentry/cli directly without having it listed in dependencies. Based on error stack trace the troublesome line of code is here: https://github.com/getsentry/sentry-javascript/blob/master/packages/nextjs/src/config/webpack.ts#L334

Until this is fixed properly you can hotfix it by adding these couple lines to yarnrc.yml:

packageExtensions:
  '@sentry/nextjs@*':
    dependencies:
      '@sentry/cli': '^1.74.4'

@AbhiPrasad Could this ticket be reopened? It's still happening even with 7.5.1 version