fix(serverless): Re-add missing modules in Node AWS Lambda Layer #4982
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the AWS Lambda layer in
@sentry/serverless
.The problem was caused by changes introduced in #4882.
Some unintended consequences of these changes were:
.npmignore
files,npm-packlist
did not find all the necessary (but also unnecessary) files when creating the list of files that should end up in the lambda layer Zip file. Due to the missing.npmignore
files, it resorted to.gitignore
which ignores generated JS files. This PR re-adds local.npmignore
files in the dependencies of@sentry/serverless
to fix this.@sentry/tracing
is a special case where we need to executeprepack.ts
also after building. The call to prepack was missing the--bundles
flag, resulting in a weird directory structure. This PR adds the flag and adjusts thesideEffects
entry we need for our integration tests.As a hotfix, this PR ensures further that the directory structure in the Lambda layer conforms to the
NODE_OPTIONS
environment variable set by SentryFixes #4949
ref: https://getsentry.atlassian.net/browse/INC-135
ref: https://getsentry.atlassian.net/browse/WEB-860