fix(nextjs): Unwrap req and res if necessary when instrumenting server
#4467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
size-limit report
|
|
Hi @lobsterkatie, Is there anything I can help with this PR? |
|
hi there, when should we expect this land? |
iker-barriocanal
approved these changes
Jan 28, 2022
|
Hey folks, we'll be cutting a patch release right after this gets merged in! Release should be out by end of day today! |
|
For those watching this PR - getsentry/publish#775 will track the state of the release. When that issue is closed, the release should be out under Edit: Released with https://www.npmjs.com/package/@sentry/nextjs/v/6.17.3 |
BitOfUniverse
added a commit
to BitOfUniverse/pancake-frontend
that referenced
this pull request
Feb 3, 2022
Recent update of Nextjs broke integration with Sentry and requires update for Sentry package. vercel/next.js#33726 Issue was fixed here: getsentry/sentry-javascript#4467
BitOfUniverse
added a commit
to BitOfUniverse/pancake-frontend
that referenced
this pull request
Feb 3, 2022
Recent update of Nextjs broke integration with Sentry and requires update for Sentry package. vercel/next.js#33726 Issue was fixed here: getsentry/sentry-javascript#4467
BitOfUniverse
added a commit
to BitOfUniverse/pancake-frontend
that referenced
this pull request
Feb 3, 2022
Recent update of Nextjs broke integration with Sentry and requires update for Sentry package. vercel/next.js#33726 Issue was fixed here: getsentry/sentry-javascript#4467
BitOfUniverse
added a commit
to BitOfUniverse/pancake-frontend
that referenced
this pull request
Feb 3, 2022
Recent update of Nextjs broke integration with Sentry and requires update for Sentry package. vercel/next.js#33726 Issue was fixed here: getsentry/sentry-javascript#4467
chef-jojo
pushed a commit
to pancakeswap/pancake-frontend
that referenced
this pull request
Feb 3, 2022
Recent update of Nextjs broke integration with Sentry and requires update for Sentry package. vercel/next.js#33726 Issue was fixed here: getsentry/sentry-javascript#4467
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
h/t to @YukiKitagata for finding the relevant change to Next.js and providing an initial implementation of this fix.
In vercel/next.js#32999 (released as part of 12.0.9), Next.js made an internal change, so that it now wraps the raw
http.IncomingMessageandhttp.ServerResponseobjects which get passed to the main server request handler inNodeNextRequestandNodeNextResponseobjects, respectively. We therefore need to unwrap them before we can use them.This does that unwrapping (if necessary; older versions of nextjs still don't need it) and fixes the relevant types.
Fixes #4463
Fixes vercel/next.js#33726