Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(ember): Remove Ember source from main deps #3969

Closed
wants to merge 1 commit into from
Closed

ref(ember): Remove Ember source from main deps #3969

wants to merge 1 commit into from

Conversation

k-fish
Copy link
Member

@k-fish k-fish commented Sep 9, 2021

Ember source only needs to be included as a dev dep for addons.

Fixes #3962

@k-fish
ref(ember): Remove Ember source from main deps
caa67c6 
Ember source only needs to be included as a dev dep for addons.

Fixes #3962
@k-fish
Copy link
Member Author

k-fish commented Sep 9, 2021

Actually, the original fix is fine, closing in lieu of it 😄

@k-fish k-fish closed this Sep 9, 2021
@AbhiPrasad AbhiPrasad deleted the ref/ember-remove-source-dep branch September 9, 2021 15:22
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2021

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 21.66 KB (-0.01% 🔽)
@sentry/browser - Webpack 22.67 KB (0%)
@sentry/react - Webpack 22.71 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 29.09 KB (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@kamilogorek kamilogorek Awaiting requested review from kamilogorek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@k-fish @AbhiPrasad