Add protocol detection for get/request calls without explicit protocol

[thomaspurchas]

You can call get/request on http/https without providing an
explicit protocol in the request options. In this case the protocol is
automatically set based on which module you made the call to.

Previously calls like this would result in breadcrumbs and traces
without a protocol in the URL creating downstream issues for consumers
of Breadcrumbs as the missing protocol results in URL throwing parsing
errors.

We now attempt to get the protocol by either extracting it from the
agent passed as part of the request options, or by extracting it from
the globalAgent on which ever http module is pass in this.

Fixes #3948

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

• If you've added code that should be tested, please add tests.
• Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

[AbhiPrasad]

Thanks for your contribution!

You can fix the lint CI errors by running yarn lint:fix. As for the Node 6,8 test failures, seems like there is an issue with the awaiting the promise. Maybe we can convert to just relying on callbacks?

[thomaspurchas]

Fixed the lint issues. Tracking down the Node v8/6 bug was a little tricker, turned out that was related to how nock works, and how nocks patching interacts with Sentry's patching. Left a big comment explaining the very strange work around I had to use.

[kamilogorek]

That's exactly what we had to work around here

sentry-javascript/packages/node/src/integrations/http.ts

Lines 63 to 71 in 18f0e6d

	// NOTE: Prior to Node 9, `https` used internals of `http` module, thus we don't patch it.
	// If we do, we'd get double breadcrumbs and double spans for `https` calls.
	// It has been changed in Node 9, so for all versions equal and above, we patch `https` separately.
	if (NODE_VERSION.major && NODE_VERSION.major > 8) {
	const httpsModule = require('https');
	fill(httpsModule, 'get', wrappedHandlerMaker);
	fill(httpsModule, 'request', wrappedHandlerMaker);
	}
	}

but I'm sure you've seen it :)

[thomaspurchas]

Thanks for getting that merged @kamilogorek, do you have any idea when a new release is gonna get published on npm? Keen to get this patch into production.

[kamilogorek]

We have a beta release that we test now, so I'd assume it should be out early next week. Most likely Monday. I'll talk with the team today.