Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(perf): Add experimental option to improve LCP collection #3879

Merged
merged 6 commits into from Sep 14, 2021
Merged

feat(perf): Add experimental option to improve LCP collection #3879

merged 6 commits into from Sep 14, 2021

Commits on Sep 10, 2021

  1. feat(perf): Add experimental option to improve LCP collection 

    This will add an experimental option (options._metricOptions._reportAllChanges) that will set 'getLCP' to always report. Now that we are recording LCP element, it should be sufficient to collection the additional information and let the user pick the appropriate LCP element in the ui to improve accuracy dynamically instead. We'd like to test this out on Sentry first.
    @k-fish @AbhiPrasad
    k-fish authored and AbhiPrasad committed Sep 10, 2021
    Copy the full SHA
    f6a81b1 View commit details
    Browse the repository at this point in the history

  2. ref: Use explicit defaults

    @AbhiPrasad
    AbhiPrasad committed Sep 10, 2021
    Copy the full SHA
    8dda9d4 View commit details
    Browse the repository at this point in the history

  3. fix type

    @AbhiPrasad
    AbhiPrasad committed Sep 10, 2021
    Copy the full SHA
    9ffbac9 View commit details
    Browse the repository at this point in the history

  4. fix tests

    @AbhiPrasad
    AbhiPrasad committed Sep 10, 2021
    Copy the full SHA
    b6f8ece View commit details
    Browse the repository at this point in the history

  5. Make sure option is set correctly

    @AbhiPrasad
    AbhiPrasad committed Sep 10, 2021
    Copy the full SHA
    99bd218 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2021

  1. Merge branch 'master' into feat/perf-add-private-option-test-intermed… 

    …iate-lcp
    @AbhiPrasad
    AbhiPrasad committed Sep 14, 2021
    Copy the full SHA
    5aedc36 View commit details
    Browse the repository at this point in the history