Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(@sentry/nextjs): move webpack-plugin to devDeps #3866

Merged

Conversation

belgattitude
Copy link
Contributor

Trying out one option to fix #3865.

This is WIP/ Do Not Merge

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

@kamilogorek kamilogorek force-pushed the sentry-nextjs-without-webpack-plugin branch from 18b9aed to 01d6dd7 Compare September 14, 2021 13:12
@kamilogorek kamilogorek merged commit 2afd60d into getsentry:master Sep 14, 2021
@kamilogorek
Copy link
Contributor

That makes sense nonetheless. Thanks

@lobsterkatie
Copy link
Member

Actually, it doesn't. We use the webpack plugin when an SDK user builds their app, so we need to include it in our package. I'll revert this.

lobsterkatie added a commit that referenced this pull request Sep 14, 2021
…es (#3981)

This reverts the change made in #3866. The SDK user needs the webpack plugin in order to upload their sourcemaps, so it needs to be installed when they install the SDK.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[@sentry/nextjs] @sentry/cli always bundled in production
3 participants