Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(ember): Fix tests to be forward compatible with component changes #3347

Merged
merged 2 commits into from
Mar 29, 2021
Merged

ref(ember): Fix tests to be forward compatible with component changes #3347

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
702852a
ref(ember): Fix tests to be forward compatible with component changes
k-fish Mar 25, 2021
a73a4d1
Update packages/ember/tests/acceptance/sentry-performance-test.js
k-fish Mar 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/ember/tests/acceptance/sentry-performance-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,11 @@ function assertSentryCall(assert, callNumber, options) {
}
if (options.spans) {
assert.deepEqual(
event.spans.map(s => `${s.op} | ${s.description}`),
event.spans.map(s => {
// Normalize span descriptions for internal components so tests work on either side of updated Ember versions
const normalizedDescription = s.description === 'component:-link-to' ? 'component:link-to' : s.description;
return `${s.op} | ${normalizedDescription}`;
}),
options.spans,
`Has correct spans`,
);
Expand Down