Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Create spanRecorder whenever transactions are sampled #3255

Merged
merged 3 commits into from
Feb 12, 2021
Merged

fix: Create spanRecorder whenever transactions are sampled #3255

merged 3 commits into from
Feb 12, 2021

Commits on Feb 12, 2021

  1. fix: Create spanRecorder whenever transactions are sampled 

    There were cases in which the sample function would return early without
correctly setting up a spanRecorder, causing child spans to be lost.
    @rhcarvalho
    rhcarvalho committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    cfb13bc View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Kamil Ogórek <kamil.ogorek@gmail.com>
    @rhcarvalho @kamilogorek
    rhcarvalho and kamilogorek committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    d4a4d82 View commit details
    Browse the repository at this point in the history

  3. Fix arg name

    @rhcarvalho
    rhcarvalho committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    19e03fa View commit details
    Browse the repository at this point in the history