Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Move creation of iframe in try/catch #2447

Merged
merged 1 commit into from
Feb 21, 2020
Merged

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Feb 21, 2020

@HazAT HazAT self-assigned this Feb 21, 2020
@getsentry-bot
Copy link
Contributor

getsentry-bot commented Feb 21, 2020

Messages
📖 ✅ TSLint passed
📖

@sentry/browser bundle gzip'ed minified size: (ES5: 16.6885 kB) (ES6: 15.707 kB)

Generated by 🚫 dangerJS against 132eb62

Copy link
Member

@lobsterkatie lobsterkatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@HazAT HazAT merged commit daf7a6d into master Feb 21, 2020
@HazAT HazAT deleted the fix/move-sandbox-check branch February 21, 2020 12:11
@seamereth
Copy link

Thanks for fixing so quickly @HazAT . is there any way we can get this pushed to npm? not sure how these things work but the sooner the better as Sentry is completely broken for me ATM

@bill-pairaktaridis
Copy link

+1 on getting this to npm. Thanks for your efforts @HazAT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sentry.init() is throwing an error evaluating 'sandbox.hidden = true'
5 participants