Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser/ember: Rethrow errors in testing mode #1696

Merged
merged 1 commit into from Oct 31, 2018

Conversation

Turbo87
Copy link
Contributor

@Turbo87 Turbo87 commented Oct 26, 2018

see emberjs/ember-qunit#304

When there is another error handler defined we still call it and rely on that one to rethrow the error in testing mode, but when there is no other handler we should make sure to rethrow the error ourselves.

Resolves #1708

/cc @rwjblue

@rwjblue
Copy link

rwjblue commented Oct 26, 2018

tldr; This change looks good, thank you @Turbo87!

In general, I would expect not to have a Ember.onerror set at all during tests (but this is likely a conversation for another issue 😝 ). However, if you must define one then it definitely needs to rethrow when Ember.testing is set (or it will fail the Ember.onerror validation tests that is ran against every app by ember-qunit).

@kamilogorek
Copy link
Contributor

Thanks! :)

@kamilogorek kamilogorek merged commit 17e86a2 into getsentry:master Oct 31, 2018
@Turbo87 Turbo87 deleted the rethrow branch May 3, 2019 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants