Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): Do not create GraphQL resolver spans by default #12097

Merged
merged 1 commit into from
May 17, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented May 17, 2024

Users can pass ignoreResolveSpans and ignoreTrivalResolveSpans to the integration now, which is passed to the instrumentation. They default to true. This should reduce noise and perf overhead.

Closes #12092

Users can pass `ignoreResolveSpans` and `ignoreTrivalResolveSpans` to the integration now, which is passed to the instrumentation. This should reduce noise and perf overhead.
@mydea mydea self-assigned this May 17, 2024
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable to me!

Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser 21.72 KB (0%)
@sentry/browser (incl. Tracing) 32.86 KB (0%)
@sentry/browser (incl. Tracing, Replay) 68.21 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.6 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 72.25 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 84.25 KB (0%)
@sentry/browser (incl. Feedback) 37.68 KB (0%)
@sentry/browser (incl. sendFeedback) 26.29 KB (0%)
@sentry/browser (incl. FeedbackAsync) 30.66 KB (0%)
@sentry/react 24.41 KB (0%)
@sentry/react (incl. Tracing) 35.85 KB (0%)
@sentry/vue 25.65 KB (0%)
@sentry/vue (incl. Tracing) 34.68 KB (0%)
@sentry/svelte 21.86 KB (0%)
CDN Bundle 24.26 KB (0%)
CDN Bundle (incl. Tracing) 34.29 KB (0%)
CDN Bundle (incl. Tracing, Replay) 67.99 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 72.95 KB (0%)
CDN Bundle - uncompressed 71.33 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 101.68 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 211.3 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 223.6 KB (0%)
@sentry/nextjs (client) 35.07 KB (0%)
@sentry/sveltekit (client) 33.44 KB (0%)
@sentry/node 141.35 KB (+0.02% 🔺)
@sentry/aws-serverless 128.07 KB (-0.01% 🔽)

@mydea mydea merged commit 9bbdfe7 into develop May 17, 2024
85 checks passed
@mydea mydea deleted the fn/graphql-disable-resolver-spans branch May 17, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v8: GraphQL Instrumentation increases latency on Apollo Server + Express app
2 participants