Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node): [v7] Support Node 22 #11754

Merged
merged 7 commits into from May 1, 2024
Merged

feat(node): [v7] Support Node 22 #11754

merged 7 commits into from May 1, 2024
+79 −18

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Apr 23, 2024 •
edited

tracking issue: #11455

ABI is 126: https://github.com/electron/node-abi/blob/bd11f2da07c5da324e735e2de5bf6716ce97b11c/abi_registry.json#L95-L102

Waiting for nodejs/node#52505 to release!

Added changelog entry for 7.113.0, will cut a release after this gets merged.

@AbhiPrasad AbhiPrasad mentioned this pull request Apr 23, 2024
Open
@AbhiPrasad AbhiPrasad requested review from anonrig, JonasBa, a team, mydea and lforst and removed request for a team April 24, 2024 18:45
@AbhiPrasad AbhiPrasad marked this pull request as ready for review April 24, 2024 18:45
@AbhiPrasad
Copy link
Member Author

I guess the node 22 docker containers have not been published yet 😅 - so we have to wait for that too

@JonasBa
Copy link
Member

JonasBa commented Apr 24, 2024

You are just too fast @AbhiPrasad 🫣

@AbhiPrasad
Copy link
Member Author

I'm taking matters into my own hands - nodejs/docker-node#2071

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 25, 2024 •
edited

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 80.8 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 71.75 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 76 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 65.36 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 35.62 KB (0%)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 35.5 KB (0%)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.59 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.6 KB (0%)
@sentry/browser - Webpack (gzipped) 22.77 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 79 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 70.34 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 36.02 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 25.28 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 221.41 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 109.01 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 75.79 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 39.3 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 72.25 KB (0%)
@sentry/react - Webpack (gzipped) 22.81 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 90 KB (+0.01% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 54.13 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 17.34 KB (0%)

@AbhiPrasad
Copy link
Member Author

blocked on docker-library/official-images#16663

@AbhiPrasad AbhiPrasad mentioned this pull request Apr 26, 2024
Open
@AbhiPrasad
Copy link
Member Author

Docker stuff is released https://hub.docker.com/_/node/tags

but late in day so we can only prob do v7 release on monday

@AbhiPrasad AbhiPrasad mentioned this pull request Apr 26, 2024
Open
@AbhiPrasad
Copy link
Member Author 

   Execute installation script
  Check if Python hostedtoolcache folder exist...
  Create Python 3.8.10 folder
  Copy Python binaries to hostedtoolcache folder
  Create additional symlinks (Required for the UsePythonVersion Azure Pipelines task and the setup-python GitHub Action)
  Upgrading pip...
  Looking in links: /tmp/tmp3o8h6q9d
  Requirement already satisfied: setuptools in /opt/hostedtoolcache/Python/3.8.10/x64/lib/python3.8/site-packages (56.0.0)
  Requirement already satisfied: pip in /opt/hostedtoolcache/Python/3.8.10/x64/lib/python3.8/site-packages (21.1.1)
  Error: Usage:   
    /opt/hostedtoolcache/Python/3.8.10/x64/bin/python -m pip install [options] <requirement specifier> [package-index-options] ...
    /opt/hostedtoolcache/Python/3.8.10/x64/bin/python -m pip install [options] -r <requirements file> [package-index-options] ...
    /opt/hostedtoolcache/Python/3.8.10/x64/bin/python -m pip install [options] [-e] <vcs project url> ...
    /opt/hostedtoolcache/Python/3.8.10/x64/bin/python -m pip install [options] [-e] <local project path> ...
    /opt/hostedtoolcache/Python/3.8.10/x64/bin/python -m pip install [options] <archive url/path> ...
  
  no such option: --root-user-action
  Error: The process '/usr/bin/bash' failed with exit code 2
  ##[debug]Node Action run completed with exit code 1
  ##[debug]Finishing: Setup python

bruh

@AbhiPrasad
Copy link
Member Author

Oh wait this is happening on master as well! https://github.com/getsentry/sentry-javascript/actions/runs/8853059168/job/24313364936

@AbhiPrasad
Copy link
Member Author

Here's the bug actions/setup-python#853

@JonasBa
Copy link
Member

JonasBa commented May 1, 2024

Just need to fix a bug with win22, I'm hoping its an issue with the minmax macro

@JonasBa JonasBa merged commit b90d046 into v7 May 1, 2024
130 checks passed
@JonasBa JonasBa deleted the abhi-node-22 branch May 1, 2024 21:13
s1gr1d pushed a commit that referenced this pull request May 2, 2024
@AbhiPrasad @JonasBa @s1gr1d
feat(node): [v7] Support Node 22 (#11754)
ee6ebd2 
tracking issue:
#11455

ABI is 126:
https://github.com/electron/node-abi/blob/bd11f2da07c5da324e735e2de5bf6716ce97b11c/abi_registry.json#L95-L102

~Waiting for nodejs/node#52505 to release!~

Added changelog entry for `7.113.0`, will cut a release after this gets
merged.

---------

Co-authored-by: JonasBa <jonas@badalic.com>
@s1gr1d s1gr1d mentioned this pull request May 2, 2024
Merged
s1gr1d added a commit that referenced this pull request May 2, 2024
@s1gr1d @AbhiPrasad @JonasBa
feat(node): Support Node 22 (#11871)
3355a05 
Port from v7: #11754

---------

Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
Co-authored-by: JonasBa <jonas@badalic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@JonasBa JonasBa JonasBa approved these changes

@mydea mydea Awaiting requested review from mydea mydea was automatically assigned from getsentry/team-web-sdk-frontend

@lforst lforst Awaiting requested review from lforst lforst was automatically assigned from getsentry/team-web-sdk-frontend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AbhiPrasad @JonasBa @anonrig