New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(replay): Add option to pass in custom record fn #11702
base: develop
Are you sure you want to change the base?
Conversation
9699435
to
5708be8
Compare
size-limit report 📦
|
Bringing back #8647 but it would be nice to test new versions of rrweb without having to bundle it with our replay SDK.
5708be8
to
0376fe3
Compare
@@ -1,5 +1,4 @@ | |||
import { record } from '@sentry-internal/rrweb'; | |||
import type { serializedElementNodeWithId, serializedNodeWithId } from '@sentry-internal/rrweb-snapshot'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, the ts3.8 tests are failing because this snapshot package uses Lowercase
(amongst others) that were introduced after 3.8 (Lowercase was added in 4.1), but we've always been pulling in types from snapshot, so not sure why they are now failing. The only difference is we are importing Mirror
type.
any ideas @AbhiPrasad?
Bringing back #8647 but it would be nice to test new versions of rrweb without having to bundle it with our replay SDK.