Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): Use ANR integration by default #11583

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Apr 12, 2024

Adds the anrIntegration to the defaults and makes captureStackTrace: true the default too.

Copy link
Contributor

github-actions bot commented Apr 12, 2024

size-limit report 📦

Path Size
@sentry/browser 22.17 KB (0%)
@sentry/browser (incl. Tracing) 31.75 KB (0%)
@sentry/browser (incl. Tracing, Replay) 67.07 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 60.47 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 70.91 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 80.8 KB (0%)
@sentry/browser (incl. Feedback) 35.73 KB (0%)
@sentry/browser (incl. Feedback, Feedback Modal) 35.73 KB (0%)
@sentry/browser (incl. Feedback, Feedback Modal, Feedback Screenshot) 37.75 KB (0%)
@sentry/browser (incl. sendFeedback) 26.97 KB (0%)
@sentry/react 24.85 KB (0%)
@sentry/react (incl. Tracing) 34.65 KB (0%)
@sentry/vue 25.74 KB (0%)
@sentry/vue (incl. Tracing) 33.46 KB (0%)
@sentry/svelte 22.3 KB (0%)
CDN Bundle 24.29 KB (0%)
CDN Bundle (incl. Tracing) 32.77 KB (0%)
CDN Bundle (incl. Tracing, Replay) 66.42 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 82.58 KB (0%)
CDN Bundle - uncompressed 72.37 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 98.36 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 208.02 KB (0%)
@sentry/nextjs (client) 34.01 KB (0%)
@sentry/sveltekit (client) 32.25 KB (0%)
@sentry/node 141.83 KB (+17.88% 🔺)

@timfish
Copy link
Collaborator Author

timfish commented Apr 12, 2024

It looks like the tests are failing in two main places:

NextJs Integration Tests

The tests are passing but timing out due to not exiting. My best guess is that because they're using the older test runner, there is no isolation between the test cases and for whatever reason something is not getting cleaned up and is keeping the process open.

Node Integration Tests

The memory leak tests fail in CI but not on my machine locally. The failure is because in 20 seconds we do not see at least 15 updates about memory usage. In CI we're seeing 8-12 memory updates. This suggests that in the constrained CI environment, the ANR worker is slowing app startup by an extra 5+ seconds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant