feat(integrations): Add zod integration #11144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a [Zod](https://github.com/colinhacks/zod) integration to sentry that adds better support for ZodError issues. Currently, the ZodError message is a formatted json string that gets truncated and the full list of issues are lost. - Adds the full list of issues to `extras['zoderror.issues']`. - Replaces the error message with a simple string.
size-limit report 📦
|
|
Hey @scttcper do you mind resolving merge conflicts (rebasing on develop), then I'll take a look - thank you! (and sorry for late response, got a bit lost there...) |
# Conflicts: # packages/node/src/index.ts
mydea
approved these changes
Apr 19, 2024
colinhacks
reviewed
Apr 19, 2024
packages/utils/src/zod-errors.ts
Outdated
| * This doesn't display well in the Sentry UI. Replace it with something shorter. | ||
| */ | ||
| function formatIssueMessage(zodError: ZodError): string { | ||
| const formError = zodError.flatten(); |
There was a problem hiding this comment.
I'd recommend against relying on .flatten here as it's liable to change in Zod 4. Instead consider iterating over the .issues array.
declare let err: z.ZodError;
const errorKeyMap = new Set<string | number | symbol>();
for (const iss of err.issues) {
if (iss.path) errorKeyMap.add(iss.path[0]);
}
const errorKeys = Array.from(errorKeyMap);
mydea
reviewed
Apr 22, 2024
mydea
requested changes
Apr 22, 2024
|
@mydea i think this is ready to go. I assume you'll merge it? I'm not up to date on what's going on with the sdk v8 |
mydea
reviewed
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a Zod integration to sentry that adds better support for ZodError issues. Currently, the ZodError message is a formatted json string that gets truncated and the full list of issues are lost.
extras['zoderror.issues'].before
after
