Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(replay): Fix flakey extendNetworkBreadcrumbs/fetch tests #11142

Merged
merged 13 commits into from
May 13, 2024
Merged

test(replay): Fix flakey extendNetworkBreadcrumbs/fetch tests #11142

merged 13 commits into from
May 13, 2024

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Mar 15, 2024 •
edited

See #11140

Closes #9119

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 15, 2024 •
edited

size-limit report 📦

Path Size
@sentry/browser 21.65 KB (0%)
@sentry/browser (incl. Tracing) 32.69 KB (0%)
@sentry/browser (incl. Tracing, Replay) 68.04 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.44 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 72.08 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 84.08 KB (0%)
@sentry/browser (incl. Feedback) 37.58 KB (0%)
@sentry/browser (incl. sendFeedback) 26.21 KB (0%)
@sentry/browser (incl. FeedbackAsync) 30.58 KB (0%)
@sentry/react 24.33 KB (0%)
@sentry/react (incl. Tracing) 35.66 KB (0%)
@sentry/vue 25.48 KB (0%)
@sentry/vue (incl. Tracing) 34.49 KB (0%)
@sentry/svelte 21.78 KB (0%)
CDN Bundle 24.13 KB (0%)
CDN Bundle (incl. Tracing) 34.06 KB (0%)
CDN Bundle (incl. Tracing, Replay) 67.74 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 72.71 KB (0%)
CDN Bundle - uncompressed 70.99 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 101.03 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 210.65 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 222.94 KB (0%)
@sentry/nextjs (client) 34.88 KB (0%)
@sentry/sveltekit (client) 33.26 KB (0%)
@sentry/node 147.44 KB (0%)

@billyvg billyvg force-pushed the test-replay-flakes-integration-network-crumbs branch from a2b9f7b to 9e8e3fd Compare April 15, 2024 18:57
@billyvg
Copy link
Member Author

billyvg commented Apr 16, 2024

Hmm, this initially had one failure: https://github.com/getsentry/sentry-javascript/actions/runs/8694566474/job/23843750002#step:13:1628

But I just ran it 4 times w/o any issues in the flakey test detector workflow:

image

@billyvg billyvg marked this pull request as ready for review April 17, 2024 19:22
@billyvg
Copy link
Member Author

billyvg commented Apr 17, 2024

Ran 2 more times without flakes ¯_(ツ)_/¯

@billyvg billyvg requested a review from a team as a code owner May 13, 2024 14:59
@billyvg @mydea
Update .github/workflows/flaky-test-detector.yml
cfdcb3a 
Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
@billyvg
Copy link
Member Author

billyvg commented May 13, 2024

😬
image

@billyvg billyvg merged commit 1390402 into develop May 13, 2024
99 checks passed
@billyvg billyvg deleted the test-replay-flakes-integration-network-crumbs branch May 13, 2024 20:24
andreiborza pushed a commit that referenced this pull request May 16, 2024
@billyvg @mydea @andreiborza
test(replay): Fix flakey extendNetworkBreadcrumbs/fetch tests (#11142)
6ce0841 
See #11140


Closes #9119

---------

Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mydea mydea mydea approved these changes

@Lms24 Lms24 Lms24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Flaky CI]: suites/replay/extendNetworkBreadcrumbs
3 participants
@billyvg @mydea @Lms24