fix(react): Passes the fallback function through React's createElement function #10623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…This enables the fallback component to use hooks
|
Hey @MFoster - mind writing some tests for this? Thanks! |
…s a test that was ensuring a function that returned a string would result in a null node. React considers a string to be valid and was creating an element with the string within, changes that function to return undefined instead of a string.
|
@AbhiPrasad Added a test that proves the ability to call hooks. |
|
CI is failing on formatting - you can run |
AbhiPrasad
changed the title
AbhiPrasad
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Thanks for your patience with this!
Now this is correct behavior, but I fear that it might be unexpected for some users, so I'm going to merge this into develop and release it as part of our new upcoming major version 8.0.0. #9508
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the fallback component used by the React Error Boundary to use hooks.