Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(remix): Make @remix-run/router a dependency. #10479

Merged
merged 3 commits into from Feb 21, 2024
Merged

ref(remix): Make @remix-run/router a dependency. #10479

merged 3 commits into from Feb 21, 2024

Conversation

onurtemizkan
Copy link
Collaborator

@onurtemizkan onurtemizkan commented Feb 2, 2024 •
edited

Fixes: #10349
Related: #5860
Related: #10458

Removes dynamic loading of react-router-dom and makes @remix-run/router a peer dependency.

We don't need to dynamically load react-router-dom as our TypeScript version is now up-to-date.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 2, 2024 •
edited

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.77 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.03 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.96 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.54 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.25 KB (-0.02% 🔽)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.14 KB (-0.03% 🔽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.13 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.13 KB (0%)
@sentry/browser - Webpack (gzipped) 22.41 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 76 KB (-0.04% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.52 KB (-0.04% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.48 KB (-0.07% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.69 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 212.25 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 100.97 KB (-0.06% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.87 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.78 KB (-0.05% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.33 KB (-0.02% 🔽)
@sentry/react - Webpack (gzipped) 22.44 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 86.81 KB (-0.02% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 50.05 KB (-0.03% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 17.16 KB (0%)

@onurtemizkan onurtemizkan force-pushed the onur/remix-router-as-dependency branch 6 times, most recently from 450ace8 to 34733f0 Compare February 5, 2024 17:31
@AbhiPrasad
Copy link
Member

Is this ready to merge?

@onurtemizkan onurtemizkan force-pushed the onur/remix-router-as-dependency branch 4 times, most recently from 746f2ea to 4e3837e Compare February 16, 2024 15:26
@onurtemizkan onurtemizkan marked this pull request as ready for review February 16, 2024 15:30
@onurtemizkan
Copy link
Collaborator Author

@AbhiPrasad, I think this is ready to go now.

@AbhiPrasad
Copy link
Member

Let's fix the merge conflicts and we can merge it in! Needs to probably be backported onto v7 as well.

@AbhiPrasad AbhiPrasad merged commit 674a8f0 into develop Feb 21, 2024
96 checks passed
@AbhiPrasad AbhiPrasad deleted the onur/remix-router-as-dependency branch February 21, 2024 20:27
@AbhiPrasad
Copy link
Member

@onurtemizkan mind cherry picking this and opening another PR against v7 branch? we should backport this release.

onurtemizkan added a commit that referenced this pull request Feb 21, 2024
@onurtemizkan
ref(remix): Make @remix-run/router a dependency. (#10479)
670973b 
Fixes: #10349
Related: #5860
Related: #10458

Removes dynamic loading of `react-router-dom` and makes
`@remix-run/router` a peer dependency.

We don't need to dynamically load `react-router-dom` as our TypeScript
version is now up-to-date.
@onurtemizkan onurtemizkan mentioned this pull request Feb 21, 2024
Merged
AbhiPrasad pushed a commit that referenced this pull request Feb 21, 2024
@onurtemizkan
ref(remix): Make @remix-run/router a dependency (v7) (#10779)
91c7f07 
Backports #10479 to v7 branch

Original PR Description:
> Fixes: #10349
> Related: #5860
> Related: #10458
> 
> Removes dynamic loading of `react-router-dom` and makes
`@remix-run/router` a peer dependency.
> 
> We don't need to dynamically load `react-router-dom` as our TypeScript
version is now up-to-date.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to initialize on server infrastructure (backend use-case)
2 participants
@onurtemizkan @AbhiPrasad