Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(replay-canvas): Add missing dependency on @sentry/utils #10279

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

Methuselah96
Copy link
Contributor

@Methuselah96 Methuselah96 commented Jan 21, 2024

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

- [ ] If you've added code that should be tested, please add tests. N/A

  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

Fixes #10266

The built version of @sentry-internal/replay-canvas imports from @sentry/utils, and should therefore list @sentry/utils as one of its dependencies.

image

@mydea
Copy link
Member

mydea commented Jan 22, 2024

Ah, that's a bit tricky of course! I wonder if replay actually needs this build step (unrelated to this pr!), need to check what es level is actually needed here - cc @billyvg & @lforst , something to potentially revisit in V8.

@lforst
Copy link
Member

lforst commented Jan 23, 2024

Thank you! <3

@lforst lforst merged commit 6868256 into getsentry:develop Jan 23, 2024
66 checks passed
@Methuselah96 Methuselah96 deleted the sentry-utils-dep branch January 23, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module not found: Error: Can't resolve '@sentry/utils'
3 participants