fix(utils): Fix isPlainObject() check for classes
#10242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 馃摝
|
Lms24
approved these changes
Jan 18, 2024
| return false; | ||
| } | ||
|
|
||
| try { |
There was a problem hiding this comment.
l: let's add a comment why we're looking at the ctor name
|
OK, actually this has considerable effects, as we are using this "incorrect" behavior in most places - mostly wherever we check exceptions being passed 馃槵 So I guess I'll just fix this in this one place, and then in v8 we can change this behavior and have a new utility for POJO or class instance... |
|
replaced by #10245 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns it this was just wrong, it incorrectly returned
truefor class instances 馃槵 not sure if this used to work at some point, but it's very easy to reproduce this... and there were no tests 馃槵 馃樋