Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Add withActiveSpan #10195

Merged
merged 1 commit into from
Jan 16, 2024
Merged

feat(core): Add withActiveSpan #10195

merged 1 commit into from
Jan 16, 2024

Conversation

lforst
Copy link
Member

@lforst lforst commented Jan 16, 2024

Similar to #10194

Adds withActiveSpan to the core package that will fork the current scope and set the provided span as active within the provided callback. Any startSpan calls within the callback will have the provided span as a child span.

We need this in situations where we need to pick up and create children for spans from a different execution context.

@lforst lforst requested review from mydea and Lms24 January 16, 2024 12:13
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lforst lforst merged commit a1f4a3e into develop Jan 16, 2024
96 checks passed
@lforst lforst deleted the lforst-core-with-active-span branch January 16, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants