Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replay): Update rrweb to 2.7.3 #10072

Merged
merged 1 commit into from
Jan 10, 2024
Merged

feat(replay): Update rrweb to 2.7.3 #10072

merged 1 commit into from
Jan 10, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Jan 5, 2024

This bump contains the following changes:

  • fix(rrweb): Use unpatched requestAnimationFrame when possible #150
  • ref: Avoid async in canvas #143
  • feat: Bundle canvas worker manually #144
  • build: Build for ES2020 #142

Extracted out from #9826

Closes #6946

@mydea mydea requested a review from billyvg January 5, 2024 08:09
@mydea mydea self-assigned this Jan 5, 2024
Copy link
Contributor

github-actions bot commented Jan 5, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 76.37 KB (-0.32% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 67.78 KB (-0.3% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 61.38 KB (-0.38% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.79 KB (-1.4% 🔽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 30.5 KB (-0.73% 🔽)
@sentry/browser - Webpack (gzipped) 21.87 KB (-1.01% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 74.08 KB (-0.16% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 65.73 KB (-0.15% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 31.6 KB (-1.23% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 23.52 KB (-0.91% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 206.93 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 95.02 KB (-1.72% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 69.9 KB (-1.47% 🔽)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 34.53 KB (-1.24% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 68.14 KB (-0.31% 🔽)
@sentry/react - Webpack (gzipped) 21.91 KB (-0.98% 🔽)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 84.86 KB (-0.26% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 48.97 KB (-0.95% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 16.53 KB (-1.24% 🔽)

Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested against #10079 and it seems to work -- let's wait until we get the ReplayCanvas PR to work before merging?

@mydea
Copy link
Member Author

mydea commented Jan 8, 2024

Tested against #10079 and it seems to work -- let's wait until we get the ReplayCanvas PR to work before merging?

So I think this (and probably some follow up work) will be necessary to get the ReplayCanvas PR to work 😬 as I think it's mostly rrweb changes necessary to make this work. But we can do it either way, can also bundle the rrweb updates into that PR if we want.

- fix(rrweb): Use unpatched requestAnimationFrame when possible [#150](getsentry/rrweb#150)
- ref: Avoid async in canvas (#143)
- feat: Bundle canvas worker manually (#144)
- build: Build for ES2020 (#142)
@billyvg
Copy link
Member

billyvg commented Jan 9, 2024

Manually tested this and it seems to work fine

@mydea mydea merged commit a157d98 into develop Jan 10, 2024
95 checks passed
@mydea mydea deleted the fn/update-rrweb branch January 10, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replay is making my Angular app super slow
3 participants