ci(e2e): Don't run E2E tests on forked PRs #6063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
reviewed
Oct 27, 2022
| @@ -620,7 +620,7 @@ jobs: | |||
| job_e2e_tests: | |||
| name: E2E Tests | |||
| # We only run E2E tests for non-fork PRs because the E2E tests require secrets to work and they can't be accessed from forks | |||
| if: github.repository == 'getsentry/sentry-javascript' | |||
| if: github.event.pull_request.head.repo.full_name == github.repository | |||
There was a problem hiding this comment.
This seems to skip the e2e tests in general, wonder why the initial check doesn't work.
There was a problem hiding this comment.
What makes you think that? Tried here in a non-fork and they are executed: #6064
There was a problem hiding this comment.
github.event.pull_request.head.repo.full_nameis equal to the repository where the HEAD is located.github.repositoryis equal to the repository where CI runs
There was a problem hiding this comment.
That it was skipped here https://github.com/getsentry/sentry-javascript/actions/runs/3337046260/jobs/5523555712
There was a problem hiding this comment.
That is because this PR comes from a fork - to test this behaviour
There was a problem hiding this comment.
Well I’m a complete dummy - didn’t even take that in. Well then awesome 
AbhiPrasad
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous attempts to not run E2E tests on PRs didn't work so here we go again. We do this because we cannot run the E2E tests on forks because they require secrets that GitHub doesn't provide in fork actions.
This PR was done via fork so we can actually confirm this is working.