ref(nextjs): Don't assert existance of pageProps
in _app
#5945
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the Next.js docs tell users to call
App.getInitialProps(appContext)
in their custom_app
pages, many of them don't and this will crash our implementation because the user'sgetInitialProps
will most likely not contain apageProps
property.This PR adds a simple check if the
pageProps
are there, and inserts them if they aren't. This should not have any negative consequences.