fix(browser): Set : as a part of gecko protocol regex group.

[onurtemizkan]

Fixes: #4138

The original issue about file keyword also happens for everything in that group, such as http, blob and so on. And the problem originates from : .* between that group and :. It seems that : follows those keywords without anything in between, as far as I have seen from the tests.

Removing that from the regex solved the issue without breaking any tests other than safari-extension and safari-web-extension, which are special-cased here, adding those two to the matching group also solved the issue of an extra : coming from there.

[github-actions]

size-limit report

Path	Base Size (44e0841)	Current Size	Change
@sentry/browser - CDN Bundle (gzipped)	20.24 KB	20.25 KB	+0.04% 🔺
@sentry/browser - CDN Bundle (minified)	64.29 KB	64.32 KB	+0.06% 🔺
@sentry/browser - Webpack	22.22 KB	22.22 KB	+0.02% 🔺
@sentry/browser - Webpack - gzip = false	75.7 KB	75.74 KB	+0.05% 🔺
@sentry/react - Webpack	22.25 KB	22.26 KB	+0.02% 🔺
@sentry/nextjs Client - Webpack	46.35 KB	46.36 KB	+0.02% 🔺
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped)	28.34 KB	28.35 KB	+0.04% 🔺

[AbhiPrasad]

We can cut a beta and test this - no need to enforce that it needs to be part of the next immediate release.

Also, we only tested latest firefox back when we were using BrowserStack regularly, I think as long as we can validate with playwright that this doesn't break anything, we should be good!

sentry-javascript/packages/browser/test/integration/browsers.js

Lines 123 to 130 in 20d5fa7

	bs_firefox: {
	base: "BrowserStack",
	browser: "Firefox",
	browser_version: "latest",
	os: "Windows",
	os_version: "10",
	device: null,
	real_mobile: null,

[AbhiPrasad]

I'm going to set this as blocked, let's get the e2e tests in first, and then try to merge this in.

[github-actions]

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

[AbhiPrasad]

@onurtemizkan can we rebase and add an integration test for this now?

[lobsterkatie]

Looks pretty good! My feedback is mostly just making sure things are clearer for the reader.

[AbhiPrasad]

@onurtemizkan is it possible to re-create this PR when you get some time? The stacktrace parsing logic has moved, so probably not worth it to rebase the PR.

[github-actions]

size-limit report 📦

Path	Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified)	19.36 KB (+0.04% 🔺)
@sentry/browser - ES5 CDN Bundle (minified)	59.95 KB (+0.06% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified)	17.93 KB (+0.04% 🔺)
@sentry/browser - ES6 CDN Bundle (minified)	52.83 KB (+0.07% 🔺)
@sentry/browser - Webpack (gzipped + minified)	19.7 KB (+0.03% 🔺)
@sentry/browser - Webpack (minified)	64.17 KB (+0.06% 🔺)
@sentry/react - Webpack (gzipped + minified)	19.72 KB (+0.03% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified)	44.11 KB (+0.02% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified)	25.77 KB (+0.02% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)	24.02 KB (+0.03% 🔺)

[AbhiPrasad]

@onurtemizkan - just so we can finally close the loop on this. Mind rebasing this for a final time? Let's get it merged in!

[AbhiPrasad]

@onurtemizkan mind rebasing this PR? We had to fix some NextJS test failures with #5484

[AbhiPrasad]

^ Bump to rebase this, let's get it merged in!

[lobsterkatie]

^ Bump to rebase this, let's get it merged in!

On it!