Update packages/integration-tests/suites/stacktraces/protocol_contain…

…ing_fn_identifiers/test.ts Co-authored-by: Katie Byers <lobsterkatie@gmail.com>
getsentry · Aug 2, 2022 · 61ea3f6 · 61ea3f6
1 parent e44bce8
commit 61ea3f6
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 21 deletions.
diff --git a/packages/integration-tests/suites/stacktraces/protocol_containing_fn_identifiers/test.ts b/packages/integration-tests/suites/stacktraces/protocol_containing_fn_identifiers/test.ts
@@ -50,12 +50,16 @@ sentryTest(
   },
 );
 
-sentryTest('should not add any part of the function identifier inside filename', async ({ getLocalTestPath, page }) => {
-  const url = await getLocalTestPath({ testDir: __dirname });
+sentryTest(
+  'should not add any part of the function identifier to beginning of filename',
+  async ({ getLocalTestPath, page }) => {
+    const url = await getLocalTestPath({ testDir: __dirname });
 
-  const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url);
+    const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url);
 
-  expect(eventData.exception?.values?.[0].stacktrace?.frames).toMatchObject(
-    Array(7).fill({ filename: expect.stringMatching(/^file:\/?/) }),
-  );
-});
+    expect(eventData.exception?.values?.[0].stacktrace?.frames).toMatchObject(
+      // specifically, we're trying to avoid values like `Blob@file://path/to/file` in frames with function names like `makeBlob`
+      Array(7).fill({ filename: expect.stringMatching(/^file:\/?/) }),
+    );
+  },
+);
diff --git a/packages/integration-tests/suites/stacktraces/protocol_fn_identifiers/test.ts b/packages/integration-tests/suites/stacktraces/protocol_fn_identifiers/test.ts
@@ -50,12 +50,15 @@ sentryTest(
   },
 );
 
-sentryTest('should not add any part of the function identifier inside filename', async ({ getLocalTestPath, page }) => {
-  const url = await getLocalTestPath({ testDir: __dirname });
+sentryTest(
+  'should not add any part of the function identifier to beginning of filename',
+  async ({ getLocalTestPath, page }) => {
+    const url = await getLocalTestPath({ testDir: __dirname });
 
-  const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url);
+    const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url);
 
-  expect(eventData.exception?.values?.[0].stacktrace?.frames).toMatchObject(
-    Array(7).fill({ filename: expect.stringMatching(/^file:\/?/) }),
-  );
-});
+    expect(eventData.exception?.values?.[0].stacktrace?.frames).toMatchObject(
+      Array(7).fill({ filename: expect.stringMatching(/^file:\/?/) }),
+    );
+  },
+);
diff --git a/packages/integration-tests/suites/stacktraces/regular_fn_identifiers/test.ts b/packages/integration-tests/suites/stacktraces/regular_fn_identifiers/test.ts
@@ -53,12 +53,16 @@ sentryTest(
   },
 );
 
-sentryTest('should not add any part of the function identifier inside filename', async ({ getLocalTestPath, page }) => {
-  const url = await getLocalTestPath({ testDir: __dirname });
+sentryTest(
+  'should not add any part of the function identifier to beginning of filename',
+  async ({ getLocalTestPath, page }) => {
+    const url = await getLocalTestPath({ testDir: __dirname });
 
-  const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url);
+    const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url);
 
-  expect(eventData.exception?.values?.[0].stacktrace?.frames).toMatchObject(
-    Array(8).fill({ filename: expect.stringMatching(/^file:\/?/) }),
-  );
-});
+    expect(eventData.exception?.values?.[0].stacktrace?.frames).toMatchObject(
+      // specifically, we're trying to avoid values like `Blob@file://path/to/file` in frames with function names like `makeBlob`
+      Array(8).fill({ filename: expect.stringMatching(/^file:\/?/) }),
+    );
+  },
+);