Idle transaction refactoring #3988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naseemkullah
force-pushed
the
idle-transaction-refactoring
branch
from
d3c5c18
to
d0e7ad7
Compare
naseemkullah
force-pushed
the
idle-transaction-refactoring
branch
from
ff24d8e
to
efff4c0
Compare
AbhiPrasad
approved these changes
Sep 18, 2021
| @@ -232,14 +234,12 @@ export class IdleTransaction extends Transaction { | |||
| * If this occurs we finish the transaction. | |||
| */ | |||
| private _beat(): void { | |||
| clearTimeout(this._heartbeatTimer); | |||
There was a problem hiding this comment.
Now I’m wondering why we had this clear timeout logic in the first place 🤔
My pleasure! Was looking trying to figure out why all our transactions result in failed heartbeats despite the long idle timeout setting and refactored along the way. Still not sure why, will continue investigating though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @AbhiPrasad
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).