dedupe HEARTBEAT_INTERVAL between src and test

getsentry · Sep 18, 2021 · efff4c0 · efff4c0
1 parent f1eb74d
commit efff4c0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/packages/tracing/src/idletransaction.ts b/packages/tracing/src/idletransaction.ts
@@ -7,6 +7,7 @@ import { SpanStatus } from './spanstatus';
 import { Transaction } from './transaction';
 
 export const DEFAULT_IDLE_TIMEOUT = 1000;
+export const HEARTBEAT_INTERVAL = 5000;
 
 /**
  * @inheritDoc
@@ -265,7 +266,7 @@ export class IdleTransaction extends Transaction {
     logger.log(`pinging Heartbeat -> current counter: ${this._heartbeatCounter}`);
     setTimeout(() => {
       this._beat();
-    }, 5000);
+    }, HEARTBEAT_INTERVAL);
   }
 }
 

diff --git a/packages/tracing/test/idletransaction.test.ts b/packages/tracing/test/idletransaction.test.ts
@@ -1,7 +1,12 @@
 import { BrowserClient } from '@sentry/browser';
 import { Hub } from '@sentry/hub';
 
-import { DEFAULT_IDLE_TIMEOUT, IdleTransaction, IdleTransactionSpanRecorder } from '../src/idletransaction';
+import {
+  DEFAULT_IDLE_TIMEOUT,
+  HEARTBEAT_INTERVAL,
+  IdleTransaction,
+  IdleTransactionSpanRecorder,
+} from '../src/idletransaction';
 import { Span } from '../src/span';
 import { SpanStatus } from '../src/spanstatus';
 
@@ -177,7 +182,6 @@ describe('IdleTransaction', () => {
 
   describe('heartbeat', () => {
     it('does not mark transaction as `DeadlineExceeded` if idle timeout has not been reached', () => {
-      const HEARTBEAT_INTERVAL = 5000;
       // 20s to exceed 3 heartbeats
       const transaction = new IdleTransaction({ name: 'foo' }, hub, 20000);
       const mockFinish = jest.spyOn(transaction, 'finish');