fix(utils): Ensure dropUndefinedKeys() does not break class instances
#10245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
approved these changes
Jan 18, 2024
size-limit report 📦
|
mydea
force-pushed
the
fn/dropUndefinedKeysPojo
branch
from
d95b132
to
ae34000
Compare
mydea
commented
Jan 18, 2024
| @@ -144,3 +145,27 @@ describe('isVueViewModel()', () => { | |||
| expect(isVueViewModel({ foo: true })).toEqual(false); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('isPlainObject', () => { | |||
There was a problem hiding this comment.
While at it, I at least added tests here for the current behavior!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old implementation of
dropUndefinedKeys()could break things, because it usedisPlainObject()which actually does not check if something is a POJO, but just any object. So any class instance found somewhere would be broken by this.This PR fixes this to check for POJOs better, and leaves class instances alone.
Supersedes https://github.com/getsentry/sentry-javascript/pull/10242/files